[openstreetmap/openstreetmap-website] Remove assert_response when followed by assert_redirected_to (PR #4554)

[Anton Khorev]

`assert_redirected_to` does `assert_response` anyway:

https://github.com/rails/rails/blob/6f0d1ad14b92b9f5906e44740fce8b4f1c7075dc/actionpack/lib/action_dispatch/testing/assertions/response.rb#L61
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4554

-- Commit Summary --

  * Remove assert_response when followed by assert_redirected_to

-- File Changes --

    M test/controllers/accounts_controller_test.rb (6)
    M test/controllers/changesets_controller_test.rb (7)
    M test/controllers/confirmations_controller_test.rb (11)
    M test/controllers/diary_entries_controller_test.rb (27)
    M test/controllers/export_controller_test.rb (2)
    M test/controllers/issue_comments_controller_test.rb (2)
    M test/controllers/issues_controller_test.rb (12)
    M test/controllers/messages_controller_test.rb (2)
    M test/controllers/oauth2_applications_controller_test.rb (8)
    M test/controllers/oauth2_authorizations_controller_test.rb (4)
    M test/controllers/oauth2_authorized_applications_controller_test.rb (3)
    M test/controllers/oauth_clients_controller_test.rb (9)
    M test/controllers/passwords_controller_test.rb (6)
    M test/controllers/preferences_controller_test.rb (2)
    M test/controllers/profiles_controller_test.rb (4)
    M test/controllers/redactions_controller_test.rb (11)
    M test/controllers/reports_controller_test.rb (4)
    M test/controllers/sessions_controller_test.rb (7)
    M test/controllers/site_controller_test.rb (10)
    M test/controllers/traces_controller_test.rb (10)
    M test/controllers/user_blocks_controller_test.rb (7)
    M test/controllers/users_controller_test.rb (24)
    M test/integration/client_applications_test.rb (1)
    M test/integration/oauth2_test.rb (1)
    M test/integration/oauth_test.rb (2)
    M test/integration/redirect_test.rb (23)
    M test/integration/user_creation_test.rb (60)
    M test/integration/user_login_test.rb (99)
    M test/integration/user_terms_seen_test.rb (2)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4554.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4554.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4554
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4554 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240302/57c6afd7/attachment-0001.htm>