[openstreetmap/openstreetmap-website] Rename api old element actions and path helpers (PR #4557)
Tom Hughes
notifications at github.com
Sun Mar 3 18:59:36 UTC 2024
I think historically we've only added the api prefix where we needed to disambiguate, something which I ran into last weekend when I needed to do exactly that for the changeset unsubscribe action.
I think it probably does make sense to do it consistently though to avoid any future issues with conflicts though.
The only thing I'm not sure about here is the user of `resources` and treating the version as the key for the resource - it's not exactly the normal rails model but then having a composite key made up of id+version isn't either... I'd like to here what @gravitystorm thinks before merging this one though.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4557#issuecomment-1975264179
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/4557/c1975264179 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240303/c4fc936e/attachment.htm>
More information about the rails-dev
mailing list