[openstreetmap/openstreetmap-website] Re-arrange login and signup screens as discussed in #4128 (PR #4455)

[Milan Cvetkovic]

@milan-cvetkovic commented on this pull request.



> +.nav-z-100 {
+  z-index: 100;
+}

Actually, it looks like z-index does not make any difference here. Thanks!

>  
-      <%= f.password_field :pass_crypt, :tabindex => 6 %>
-      <%= f.password_field :pass_crypt_confirmation, :tabindex => 7 %>
+      <p class="mb-3 text-muted fs-6"><%= t(".by_signing_up_html",
+                                            :tou_link => link_to(t(".tou"),
+                                                                 "https://wiki.osmfoundation.org/wiki/Terms_of_Use",
+                                                                 :target => :new),
+                                            :privacy_policy_link => link_to(t(".privacy_policy"),
+                                                                            t(".privacy_policy_url"),
+                                                                            :title => t(".privacy_policy_title"),
+                                                                            :target => :new),
+                                            :contributor_terms_link => link_to(t(".contributor_terms"),
+                                                                               t(".contributor_terms_url"),
+                                                                               :target => :new)) %></p>
+      <%= f.form_group do %>
+        <%= f.check_box :consider_pd,

Actually, I believe consider_pd is not necessary to go forward. There were comments earlier about this checkbox, there was a suggestion to remove it entirely: https://github.com/openstreetmap/openstreetmap-website/pull/4455#issuecomment-1899125291

You might be referring to TOU and privacy policy, both of them accepted implicitly by signing up, as agreed by LWG in https://github.com/openstreetmap/openstreetmap-website/pull/4455#issuecomment-1881708829.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4455#discussion_r1511560048
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4455/review/1914646735 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240304/1a9222aa/attachment-0001.htm>