[openstreetmap/openstreetmap-website] Re-arrange login and signup screens as discussed in #4128 (PR #4455)

Milan Cvetkovic notifications at github.com
Tue Mar 5 13:27:50 UTC 2024


@milan-cvetkovic commented on this pull request.



> @@ -1849,43 +1848,17 @@ en:
   sessions:
     new:
       title: "Login"

English is not my 1st language, so I need some guidance here: it is not clear to me when "log in" or "login" should be used.

OSM website was not consistent to start with: Here are the counts as reported by `grep -i "log in" config/locales/en.yml` and `grep -i "login" config/locales/en.yml` on master and this PR.

```
|        | master | this PR |
+--------+--------+---------+
| log in |    7   |    8    |
| login  |   29   |   30    |

Should I go ahead and replace all instances of "log in" with "login"?
```


-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4455#discussion_r1512824725
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4455/review/1916923702 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240305/8b0edb93/attachment.htm>


More information about the rails-dev mailing list