[openstreetmap/openstreetmap-website] Display changeset element pagination vertically (PR #4567)
Anton Khorev
notifications at github.com
Fri Mar 8 15:53:54 UTC 2024
When using #4563 without full sidebar reload, pagination links moving around becomes more annoying. It happens because sometimes they fit to the right of the "Nodes (...)" heading and sometimes they don't. We have more vertical space available and can "rotate" the links to distribute them along the right edge of the sidebar. In this case they'll always fit to the right of the heading and the element list.

Includes first commits of #4563 with refactoring.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/4567
-- Commit Summary --
* Add titles to changeset element page links
* Refactor common changeset element subpages code
* Display changeset element pagination vertically
-- File Changes --
M app/helpers/browse_helper.rb (36)
A app/views/changesets/_elements.html.erb (17)
D app/views/changesets/_paging_nav.html.erb (6)
M app/views/changesets/show.html.erb (39)
M config/locales/en.yml (2)
M lib/classic_pagination/pagination_helper.rb (6)
A test/system/changeset_elements_test.rb (27)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/4567.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4567.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4567
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/4567 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240308/b19ef568/attachment-0001.htm>
More information about the rails-dev
mailing list