[openstreetmap/openstreetmap-website] Convert note pagination to newer/older note pages (PR #4532)

Tom Hughes notifications at github.com
Tue Mar 12 19:24:12 UTC 2024


There's a number of uncontroversial changes here which aren't directly related to this PR and could be handled separately but having now spent about half an hour staring at this the core of it concerns me - it seems to be introducing an extraordinary level of complexity to me and I don't claim to understand it all yet at all.

I wonder if we're missing a trick here - although this view is a list of notes what it's really doing is listing notes in order of their more recent comment so is there a way we can use the comment ID values, which are nice and stable, as the cursor?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4532#issuecomment-1992379385
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4532/c1992379385 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240312/f1aa9a14/attachment.htm>


More information about the rails-dev mailing list