[openstreetmap/openstreetmap-website] Don't assume order when testing links to changeset elements (PR #4571)
Tom Hughes
notifications at github.com
Fri Mar 15 16:48:09 UTC 2024
I'm with @gravitystorm that this is the wrong fix - aside from the horrendous complexity involved in this fix it's fundamentally wrong to try and do pagination without a fixed order.
Without a sort you have no guarantee that the database will use the same order for each page so you may wind up seeing some things twice and not seeing others at all as you move through the pages.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4571#issuecomment-2000055576
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/4571/c2000055576 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240315/1c078c39/attachment.htm>
More information about the rails-dev
mailing list