[openstreetmap/openstreetmap-website] Don't pass paths to element_single_current_link helper (PR #4582)
Anton Khorev
notifications at github.com
Sat Mar 16 02:09:10 UTC 2024
`link_to` can often be simplified by passing to it just an object instead of a path or a controller name. This may help with refactoring. The simplification can be done in many other places in addition to what's in this PR, but just in case I'll do it in small steps, at least until #4581 is merged.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/4582
-- Commit Summary --
* Don't pass paths to element_single_current_link helper
-- File Changes --
M app/helpers/browse_helper.rb (4)
M app/views/browse/_node.html.erb (2)
M app/views/browse/_way.html.erb (4)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/4582.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4582.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4582
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/4582 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240315/0de06991/attachment-0001.htm>
More information about the rails-dev
mailing list