[openstreetmap/openstreetmap-website] Move changeset comments feed to resourceful routes (PR #4587)
Anton Khorev
notifications at github.com
Mon Mar 18 00:20:30 UTC 2024
Changeset comments as nested resources of changesets. That gives path helper names like `feed_changeset_changeset_comments_path`. At first I tried renaming "changeset_comments" to just "comments", but that didn't work because there's also a feed of all changeset comments and it takes `feed_changeset_comments_path`.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/4587
-- Commit Summary --
* Move specific changeset comments feed to resourceful routes
* Move all changeset comments feed to resourceful routes
-- File Changes --
M app/abilities/ability.rb (2)
M app/controllers/changeset_comments_controller.rb (6)
R app/views/changeset_comments/feed.rss.builder (0)
M config/locales/en.yml (2)
M config/routes.rb (8)
M test/controllers/changeset_comments_controller_test.rb (14)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/4587.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4587.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4587
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/4587 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240317/439e9b44/attachment-0001.htm>
More information about the rails-dev
mailing list