[openstreetmap/openstreetmap-website] Move changeset comments feed to resourceful routes (PR #4587)

[Anton Khorev]

> In https://github.com/openstreetmap/openstreetmap-website/pull/2050 (specifically https://github.com/openstreetmap/openstreetmap-website/commit/4b0d56f7e15d2929c973265e3b545e69273b8cb5) I renamed the comments_feed (which is what was used when the code was in changesets_controller) to the index method, since that's what most closely aligns with what this doing i.e. showing a list of objects. So I'd like to keep this as a method named index.

And I do the opposite thing in #4248 because I need the actual index path mapped to the actual index method.

> I realise that we still have feed methods elsewhere, but those are targets for refactoring too. There's a difficulty when there are already index methods that do different things (e.g. different lists of objects, or search filters, or other things, so in those cases it can't be as simple as just a respond_to switch) but in those cases I would prefer to see e.g. FooController::index and Foo::FeedController::index or similar, i.e. the method name is still index.

Then that has to be done in all cases where feeds have their own paths.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4587#issuecomment-2009950904
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4587/c2009950904 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240320/d5b697ce/attachment-0001.htm>