[openstreetmap/openstreetmap-website] Add Messages API (PR #4605)

[Anton Khorev]

@AntonKhorev commented on this pull request.



> +        raise OSM::APIAccessDenied
+      end
+
+      @message.save!
+
+      # Return a copy of the message
+      respond_to do |format|
+        format.xml { render :action => :show }
+        format.json { render :action => :show }
+      end
+    end
+
+    private
+
+    def show_messages
+      if params[:min_id]

I'm not saying you should sort by timestamps. I'm saying that instead of `min` I'd call this parameter `from`, because that's how it's already called in other places. But since in other places it's for dates and here it's for ids, I guess it should be `from_id` or maybe `from[id]`.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4605#discussion_r1535675644
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4605/review/1954950708 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240322/1c3fdb07/attachment.htm>