[openstreetmap/openstreetmap-website] Add Messages API (PR #4605)

[Anton Khorev]

@AntonKhorev commented on this pull request.



> +
+      # Return a copy of the message
+      respond_to do |format|
+        format.xml { render :action => :show }
+        format.json { render :action => :show }
+      end
+    end
+
+    private
+
+    def show_messages
+      if params[:min_id]
+        @messages = @messages.where("id >= ?", params[:min_id]) unless params[:min_id] == "0"
+        @messages = @messages.order(:id => :asc)
+      else
+        @messages = @messages.where("id <= ?", params[:max_id]) unless params[:max_id].nil? || params[:max_id] == "0"

Are you sure you want "0" as a special value for max id? Because if treated normally, it means "select messages with id <= 0", that is "select no messages at all".

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4605#pullrequestreview-1955066810
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4605/review/1955066810 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240322/ac2c4c66/attachment.htm>