[openstreetmap/openstreetmap-website] Use newer/older pagination on admin users page (PR #4625)

Anton Khorev notifications at github.com
Tue Mar 26 03:00:32 UTC 2024


![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/73d57a3d-a113-4abf-b543-5a29d18e1389)

This gets rid of classic pagination on this page. There's going to be only two pages with classic pagination after that: user blocks and changeset elements.

Differences to the previous version:

- Users are listed in the opposite order.
- Of course now there's no page numbers and it's impossible to switch to the nth page, but I don't know if this was ever used.
- Normally with before/after pagination there's no total count. Classic pagination had it, which might be useful when combined with some filter like ip address. I added the count here because there won't be any large traffic to this page.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4625

-- Commit Summary --

  * Move common pagination code to mixin
  * Make "include" and "limit" keyword args of pagination method
  * Use before/after pagination on users page
  * Add found users count to users page

-- File Changes --

    A app/controllers/concerns/pagination_methods.rb (27)
    M app/controllers/diary_entries_controller.rb (25)
    M app/controllers/traces_controller.rb (16)
    M app/controllers/users_controller.rb (15)
    M app/views/traces/index.html.erb (8)
    M app/views/users/index.html.erb (35)
    M config/locales/en.yml (8)
    M test/controllers/users_controller_test.rb (27)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4625.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4625.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4625
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4625 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240325/478f2f9d/attachment-0001.htm>


More information about the rails-dev mailing list