[openstreetmap/openstreetmap-website] Remove unused includes of ConsistencyValidations (PR #4632)
Tom Hughes
notifications at github.com
Thu Mar 28 17:12:20 UTC 2024
It's only `check_changeset_consistency` that is used in controllers - the other two methods are used in models so maybe it should be split? Though I'm not sure you could use the same name for both given that controllers can apparently find model validations, which rather surprised me.
Then again `check_changeset_consistency` is only used in one controller so is there any point in splitting it out?
This PR looks good anyway.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4632#issuecomment-2025719719
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/4632/c2025719719 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240328/234fcfac/attachment.htm>
More information about the rails-dev
mailing list