[openstreetmap/openstreetmap-website] Trace image cleanups (PR #4633)

Tom Hughes notifications at github.com
Thu Mar 28 17:32:47 UTC 2024


This further simplifies the trace image controllers by adding an `imported` scope to the trace model which eliminates a duplicate "not found" branch.

It also drops some redundant code for handling legacy traces that should have been removed in #3491.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4633

-- Commit Summary --

  * Use imported scope to simplify trace controller methods
  * Drop redundant support for legacy trace files

-- File Changes --

    M app/controllers/traces/icons_controller.rb (17)
    M app/controllers/traces/pictures_controller.rb (17)
    M app/models/trace.rb (1)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4633.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4633.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4633
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4633 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240328/b9122f8a/attachment.htm>


More information about the rails-dev mailing list