[openstreetmap/openstreetmap-website] Stop using the session to persist the referer during login (PR #4758)

Tom Hughes notifications at github.com
Mon May 6 10:14:56 UTC 2024


Using the session to persist the referer is not necessary and can be problematic in that if a login/signup is aborted partway through then the referer information can persist in the session and be reused during a later attempt.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4758

-- Commit Summary --

  * Stop using the session to persist the referer during login

-- File Changes --

    M app/controllers/concerns/session_methods.rb (13)
    M app/controllers/sessions_controller.rb (20)
    M app/controllers/users_controller.rb (34)
    M app/views/sessions/new.html.erb (2)
    M app/views/users/new.html.erb (2)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4758.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4758.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4758
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4758 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240506/8ba7760d/attachment-0001.htm>


More information about the rails-dev mailing list