[openstreetmap/openstreetmap-website] Use inline svgs for user role icons (PR #4762)

Anton Khorev notifications at github.com
Tue May 7 12:38:09 UTC 2024


An alternative to #4741. I want to change a couple of colors in "star" role icons. I'm not yet changing them here, but I'm making them easier to change by removing a bunch of files that would have to be edited.

The difference to #4741 is that I don't use a single svg file. That file would have been more complicated than a ruby method generating all role icons.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4762

-- Commit Summary --

  * Use inline svgs for user role icons
  * Use inline svgs for moderator scope icons
  * Delete role icon files

-- File Changes --

    D app/assets/images/roles/administrator.png (0)
    D app/assets/images/roles/administrator.svg (60)
    D app/assets/images/roles/blank_administrator.png (0)
    D app/assets/images/roles/blank_administrator.svg (89)
    D app/assets/images/roles/blank_importer.png (0)
    D app/assets/images/roles/blank_importer.svg (65)
    D app/assets/images/roles/blank_moderator.png (0)
    D app/assets/images/roles/blank_moderator.svg (65)
    D app/assets/images/roles/importer.png (0)
    D app/assets/images/roles/importer.svg (71)
    D app/assets/images/roles/moderator.png (0)
    D app/assets/images/roles/moderator.svg (71)
    M app/helpers/authorization_helper.rb (2)
    M app/helpers/user_roles_helper.rb (41)
    M config/locales/en.yml (2)
    M test/helpers/user_roles_helper_test.rb (264)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4762.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4762.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4762
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4762 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240507/229beb65/attachment.htm>


More information about the rails-dev mailing list