[openstreetmap/openstreetmap-website] Changeset comments have individual links, but no button to grab them with (#2796)
Andy Allan
notifications at github.com
Tue May 14 09:05:56 UTC 2024
> translations should be changed in all ~90 languages
Yes and no. You don't have to consider how this works, [you only need to make changes to en.yml](https://github.com/openstreetmap/openstreetmap-website/blob/master/CONTRIBUTING.md#i18n) and our translation team will take care of the rest.
> something like "%{comment} from %{user} %{time_ago}"¹
I wouldn't do it quite like that, I would be more likely to make the time_ago into the permalink, just like here on github comments.
> All in all, this seems a bit more complicated to me than a good first issue.
It's a reasonably isolated piece of code, it doesn't require any refactoring or other large-scale changes, so I still think it's reasonable as a good first issue. It might not be a good first issue **for you**, but that's no problem, there's plenty of other things to work on too! :smile:
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/2796#issuecomment-2109670554
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/issues/2796/2109670554 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240514/bc5e5527/attachment.htm>
More information about the rails-dev
mailing list