[openstreetmap/openstreetmap-website] OpenID connect icon to SVG (PR #4795)
Andy Allan
notifications at github.com
Wed May 15 16:04:51 UTC 2024
@gravitystorm requested changes on this pull request.
>From [CONTRIBUTING.md](https://github.com/openstreetmap/openstreetmap-website/blob/master/CONTRIBUTING.md)
* Avoid including "fixup" commits. If you have added a fixup commit (for example to fix a rubocop warning, or because you changed your own new code) please combine the fixup commit into the commit that introduced the problem. git rebase -i is very useful for this.
* Avoid including "merge" commits. If your PR can no longer be merged cleanly (for example, an unrelated change to Gemfile.lock on master now conflicts with your PR) then please rebase your PR onto the latest master. This allows you to fix the conflicts, while keeping the PR a straightforward list of commits. If there are no conflicts, then there is no need to rebase anything.
I know @tomhughes has fixed other pull requests already, but if you can fix these problems yourself before we review your PRs, then it makes it easier for everyone.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4795#pullrequestreview-2058452348
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/4795/review/2058452348 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240515/cc55c2b2/attachment.htm>
More information about the rails-dev
mailing list