[openstreetmap/openstreetmap-website] OpenID connect icon to SVG (PR #4795)
Andy Allan
notifications at github.com
Thu May 16 19:26:40 UTC 2024
> Sorry, I missed this part in the contributing guidelines. I am used to the Github feature to squash PRs into a single commit into the default branch, which uses the PR title and description as resulting commit.
No problem, thanks for making the changes
> I will squash my commits into a single commits from now on.
If it's worth having multiple commits, then please keep using multiple commits! No need to squash unnecessarily. You'll see from many of the other PRs (e.g. https://github.com/openstreetmap/openstreetmap-website/pull/4680/commits) that we use multiple commits in order to do things like allow better `git blame`, allow us to cherry-pick or revert particular commits, allow explanations of one commit separately from the rest of them, etc etc.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4795#issuecomment-2116025613
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/4795/c2116025613 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240516/ea284e65/attachment.htm>
More information about the rails-dev
mailing list