[openstreetmap/openstreetmap-website] add "edit" button to mobile version (#2233)

Anton Khorev notifications at github.com
Mon May 20 14:02:09 UTC 2024


> We also have three different layouts, not just two.

We have more than that because the following doesn't apply to the right sidebar:
 
> I should also note here that although the layout is based on the screen width, it's also (currently) affected by the language that you are using, since [the different page layouts are currently based on ensuring that the wider menus fit too](https://github.com/openstreetmap/openstreetmap-website/blob/514836a4979b655796190d60aa4bda22f9cdc7f9/app/assets/javascripts/application.js#L77-L87). Finally your username also plays a part, since it's also shown in the top menu - you can give yourself a very long username, and the edit menu will show up only on very wide screens! The exact width at which we transition from the one-column layout (for small screens) to the compact-menu layout is therefore different for different people.

You can have one sidebar going into full width mode while the other staying on the side.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/2233#issuecomment-2120526301
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/issues/2233/2120526301 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240520/ae188026/attachment.htm>


More information about the rails-dev mailing list