[openstreetmap/openstreetmap-website] Sticky close button (PR #4825)

Anton Khorev notifications at github.com
Wed May 22 01:46:13 UTC 2024


Allows close buttons to stay visible when sidebar contents is scrolled.

![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/b359a643-b39c-4a36-bd87-eeb63b57bd0b) ![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/aa30a1e5-3f45-43b8-9e00-4434adcdb119)

![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/7e85620f-59ac-4723-8ad3-a9662035ef2d) ![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/0e7d3ea4-e5a4-4e67-be56-c533d8733b5d)

Also related to [this](https://github.com/openstreetmap/openstreetmap-website/pull/4647#issuecomment-2123124562) because the button is not inside `sidebar_content` and is not being resent with page templates.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4825

-- Commit Summary --

  * Make left sidebar close button sticky
  * Make right sidebar close button sticky

-- File Changes --

    M app/assets/javascripts/index.js (2)
    M app/assets/javascripts/leaflet.sidebar-pane.js (11)
    M app/assets/javascripts/leaflet.sidebar.js (5)
    M app/assets/stylesheets/common.scss (1)
    M app/views/application/_sidebar_header.html.erb (7)
    A app/views/layouts/_sticky_close.html.erb (5)
    M app/views/layouts/map.html.erb (28)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4825.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4825.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4825
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4825 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240521/fae30bb6/attachment.htm>


More information about the rails-dev mailing list