[openstreetmap/openstreetmap-website] Adjust vertical alignment of secondary header navigation (PR #4828)

[Anton Khorev]

Like #4723 + adjustments inside the user button + increased horizontal spacing between menu items (in #4723 the spacing decreased because with `display: flex` whitespace between items gets removed).

I get rid of `h1, nav, nav > ul, nav > ul > li` selector and do other changes in order to switch later to Bootstrap navbar and decrease the number of menu/sidebar visibility modes.

Before / after when not logged in:
![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/c1ed847c-a110-4505-983b-d70cf106ef33)
![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/e41554d5-491e-4869-9f5b-81543da883da)

Before / after with issues counter:
![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/58f03eb8-1c3c-4471-8e3e-00941cf8bdbd)
![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/93ae91e9-0224-49dc-b210-184b8da650f9)

Before / after with message counter:
![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/fca587c3-995c-4ca0-b131-f1bc631349e9)
![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/15b33c81-3065-46ec-bc30-d01053a9b165)

You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4828

-- Commit Summary --

  * Use Bootstrap .nav in secondary header navigation
  * Increase secondary nav item padding to compensate removed whitespace
  * Adjust vertical alignment of user button contents

-- File Changes --

    M app/assets/stylesheets/common.scss (10)
    M app/views/layouts/_header.html.erb (8)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4828.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4828.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4828
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4828 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240524/5d0f758c/attachment.htm>