[openstreetmap/openstreetmap-website] Keep header h1 height equal to default header height (PR #4829)

Anton Khorev notifications at github.com
Fri May 24 18:40:03 UTC 2024


In small mode logo+h1 move up slightly. It seems like they shouldn't because there's `> * { height: 100%; ...}` css, but it doesn't do anything. What actually kept them from moving was `padding-top: 15px;` which I removed in #4823. I'm not going to put this padding back in. Instead I just set their height directly.

Before / after:
![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/2be97da9-afc2-4c62-b53c-b983cf351b93) ![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/8e0ea2e7-a713-400e-b30e-712e1070e4d3)

You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4829

-- Commit Summary --

  * Keep header h1 height equal to default header height

-- File Changes --

    M app/assets/stylesheets/common.scss (2)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4829.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4829.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4829
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4829 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240524/3832f429/attachment-0001.htm>


More information about the rails-dev mailing list