[openstreetmap/openstreetmap-website] Inline welcome sprite (PR #4843)

Anton Khorev notifications at github.com
Mon May 27 14:53:18 UTC 2024


> easier to maintain wen used twice

But the are not. And if you stop using these svgs, you'll have to remember to clean up the files too or else you'll end up with the files with unknown purposes. And then you'll have to do git blame investigations to find out if it's safe to remove them.

> Easier to preview from the file system during development.

Configure your editor to preview inline svg:
![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/aca09d6b-8cdb-47db-bc5f-92d6dda72949)

Previewing just from the filesystem won't tell you where the svgs are used in the code.

> The file name is a signal ob what this svg is.

Even bigger signal is the svg being exactly in the place where it's used.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4843#issuecomment-2133642036
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4843/c2133642036 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240527/d2b4a0b0/attachment.htm>


More information about the rails-dev mailing list