[openstreetmap/openstreetmap-website] Fixed "auth_button_preferred alignment" issue described in #4773 (PR #4849)

Nenad Vujicic notifications at github.com
Tue May 28 09:51:49 UTC 2024


This PR addresses "auth_button_prefered alignment" issue mentioned in the #4773

In app/views/application/_auth_providers_html.erb, updated div's styles, updated layout (parent div + 2 (or 1) child div area) and simplified code (replaced multiple nested if-statements with one-line-for-all). Here are the screenshots before and after the changes:

Before:
![image](https://github.com/openstreetmap/openstreetmap-website/assets/25298521/56a18921-7967-481c-9206-d2db6a026c93)
![image](https://github.com/openstreetmap/openstreetmap-website/assets/25298521/323e6e48-a808-4648-844f-b77432618b76)

After:
![image](https://github.com/openstreetmap/openstreetmap-website/assets/25298521/7ba61fbd-175c-42e1-9177-49483c6659f2)
![image](https://github.com/openstreetmap/openstreetmap-website/assets/25298521/27a0a71f-0341-4c84-8664-c37d03befa7c)

You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4849

-- Commit Summary --

  * Fixed "auth_button_preferred alignment" issue described in #4773

-- File Changes --

    M app/views/application/_auth_providers.html.erb (41)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4849.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4849.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4849
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4849 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240528/92f5502e/attachment.htm>


More information about the rails-dev mailing list