[openstreetmap/openstreetmap-website] Move Export button to secondary nav (PR #4854)

Anton Khorev notifications at github.com
Wed May 29 05:21:27 UTC 2024


*Export* is no longer a green outline button but rather a gray secondary navigation item.

The main reason for this is to allow *Export* to collapse into *More*. This lets the header to be narrower in *compact mode*. Hopefully then *compact mode* will be available above the Bootstrap medium breakpoint of 768px, which then can be made a fixed breakpoint for going between *small* and *compact* modes. (If not, maybe try moving the *History* button next.) See #4130.

I also don't hide the *Edit* button because it's easier not to hide it. If I kept it hidden exactly like it was before, the *History* button in the small mode menu would have had rounded borders only on one side. So coincidentally I also do here what #4839 tried to do except I don't need a vertical button group for edit-history-export. There's no *Export* in the group and *Edit*+*History* should fit horizontally.

![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/328c1f25-9755-4647-8a9d-72b3eaba06c1)
![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/44a9fa59-e182-48d7-8588-afc27844052d)
![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/9c582ba9-a112-40f7-ba00-1572469782be)


You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4854

-- Commit Summary --

  * Move Export to secondary nav
  * Close small mode menu on some interactions
  * Update secondary nav active item highlight from js router

-- File Changes --

    M app/assets/javascripts/index.js (3)
    M app/assets/javascripts/index/search.js (1)
    M app/assets/javascripts/router.js (12)
    M app/assets/stylesheets/common.scss (6)
    M app/views/layouts/_header.html.erb (11)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4854.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4854.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4854
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4854 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240528/b1d59ce7/attachment-0001.htm>


More information about the rails-dev mailing list