[openstreetmap/openstreetmap-website] Url-encode "?" characters in wikipedia tag values (PR #4855)

Andy Allan notifications at github.com
Wed May 29 09:57:41 UTC 2024


I think this isn't quite the right approach, since as you say there are probably different characters that also need escaping (for example, a wikipedia link with a forward slash in the title, if that's possible).

I think we should look for something that encodes url components, rather than making our own function. I found this interesting article:

https://bibwild.wordpress.com/2023/02/14/escaping-encoding-uri-components-in-ruby-3-2/

I think it's reasonable for us to use the `ERB:Utils` approach, since we are not yet on ruby 3.2+

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4855#issuecomment-2137020207
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4855/c2137020207 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240529/0a620eef/attachment.htm>


More information about the rails-dev mailing list