[openstreetmap/openstreetmap-website] Move Export button to secondary nav (PR #4854)

Anton Khorev notifications at github.com
Thu May 30 00:29:58 UTC 2024


I wanted to get rid of *compact mode* and move the secondary menu items in/out of *More* depending on how much space is available. It was easier to do it together with the fixed breakpoint for small mode. See #4862.

![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/78ec3396-0059-401a-9cc7-9e5b1c4824f8)
![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/ddb1a1ec-5189-4737-8042-edbd378398eb)
![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/eeea8d1f-03e7-4d47-9d0b-ce0db9f297d1)

This is how it looks if you get down to the 768px breakpoint:
![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/32940977-b34a-4467-a0c0-64f33ce9db00)

Seems to work fine, but that's in English. Here's Bulgarian, and now things don't fit even with fully collapsed secondary menu items:
![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/3c56ff25-2c2e-4204-bf5e-2c6675e9bee6)

Without the green *Export* button everything seems to fit fine:
![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/105e71b5-2444-46d3-bec7-fa682d173334)

---

One of the alternatives to moving *Export* from buttons to the secondary menu is to move *Export* dynamically to *More* if there's not enough space. *Traces*, *Diaries* etc will move between the secondary menu and *More*, *Export* will move between buttons and *More*. That'll be a little more javascript.

But does *Export* deserve to be a button? Is it used often enough to justify this spot and then this moving behavior?

One advantage could be that if *Export* is moved to *More* and there's still not enough space, it's possible to similarly move *History*. But I don't know if there's a locale that requires this.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4854#issuecomment-2138459808
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4854/c2138459808 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240529/4ea94d16/attachment.htm>


More information about the rails-dev mailing list