[openstreetmap/openstreetmap-website] Fixed "or divider" issue described in #4773 (PR #4857)

[Nenad Vujicic]

Dear @tomhughes ,

Regarding using mb-2 vs mb-3 .. When looking at distances between "Log in with Microsoft" and dividing line and dividing line and "Email Address and Username", they look more similar when using mb-2 than when using mb-3. Please, take a look at below screenshots (I can quickly switch to mb-3 if you prefer?):

mb-2:
![image](https://github.com/openstreetmap/openstreetmap-website/assets/25298521/105ad5b9-546e-4d9c-a031-a76e93151b0d)
mb-3:
![image](https://github.com/openstreetmap/openstreetmap-website/assets/25298521/99b06365-3db2-4fde-b126-376ab6fdcd58)

Regarding problems with aligning lines with the middle of the "or" text .. I moved mb-2 to upper div, and this returned us to previous alignment. The problem with making this alignment perfect is browser's layout manager uses bounding box of uppercase of the "or" label, not the lowercase (doesn't respect kerning properties). I can fix it by setting a margin, but it will create a problem again if user selects a language with big glyphs (?locale=kn, ..) or switch to uppercase "OR", but it wouldn't look so nice again .. Please, let me know if you have any other idea?

Btw, I'm constantly getting for one- or two-lines changes failing checks (yesterday, Docker, today, Tests / Ubuntu ... Ruby 3.0). Do you have ideas why do they happen or how to mitigate them?

Thanks,
Nenad.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4857#issuecomment-2139254569
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4857/c2139254569 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240530/1493148a/attachment-0001.htm>