[openstreetmap/openstreetmap-website] Communities - communities (PR #3717)

[Andy Allan]

@gravitystorm commented on this pull request.



> +  def test_edit_get_no_session
+    # arrange
+    c = create(:community)
+    # act
+    get edit_community_path(c)
+    # assert
+    assert_response :redirect
+    assert_redirected_to login_path(:referer => edit_community_path(c))
+  end

Sure, the pattern is good, full agreement there. But as the link you gave also suggests, please use blank lines rather than comments:

"Each method should group these functional sections, separated by blank lines: "

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3717#discussion_r1620897432
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3717/review/2088543465 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240530/657054ab/attachment.htm>