[openstreetmap/openstreetmap-website] Replace query marker fade animation with css (PR #5307)
Anton Khorev
notifications at github.com
Thu Nov 7 08:48:54 UTC 2024
Fixes #5305.
Currently query markers are animated using javascript which requires managing timed events. We don't do it correctly, we don't cancel them when markers are removed. That's why #5305 happens.
This PR replaces the javascript animation with the css which doesn't require any event handlers. I could have added animation end events to remove the marker layer but once faded out it doesn't affect anything and it's cleaned up in `page.unload`.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5307
-- Commit Summary --
* Replace query marker fade animation with css
-- File Changes --
M app/assets/javascripts/index/query.js (17)
M app/assets/stylesheets/common.scss (8)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/5307.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5307.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5307
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5307 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20241107/97f78b26/attachment.htm>
More information about the rails-dev
mailing list