[openstreetmap/openstreetmap-website] Restore loading spinner in richtext previews (PR #5311)

Anton Khorev notifications at github.com
Fri Nov 8 12:14:43 UTC 2024


Richtext preview loading animation was added in https://github.com/openstreetmap/openstreetmap-website/commit/eb789dbf757e760e8348e0aa75343eb53996b7e3 but later probably got broken. Its `loading` css class was removed in https://github.com/openstreetmap/openstreetmap-website/commit/df1ec6b6809b533829fc2c171699540bbb92a85b but javascript still adds/removes it to no effect.

This PR adds a Bootstrap spinner to the preview pane.

![image](https://github.com/user-attachments/assets/41f925ce-66b3-4149-abcc-5033e26ecb0b)

You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5311

-- Commit Summary --

  * Restore loading spinner in richtext previews

-- File Changes --

    M app/assets/javascripts/richtext.js (14)
    M app/views/shared/_richtext_field.html.erb (9)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5311.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5311.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5311
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5311 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20241108/63e5dd2b/attachment.htm>


More information about the rails-dev mailing list