[openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)

Anton Khorev notifications at github.com
Thu Nov 14 10:19:17 UTC 2024


@AntonKhorev commented on this pull request.



> @@ -280,8 +280,10 @@
   resource :profile, :only => [:edit, :update]
 
   # friendships
-  match "/user/:display_name/make_friend" => "friendships#make_friend", :via => [:get, :post], :as => "make_friend"
-  match "/user/:display_name/remove_friend" => "friendships#remove_friend", :via => [:get, :post], :as => "remove_friend"
+  scope "/user/:display_name" do
+    resource :follow, :only => [:create, :destroy], :path => "follow"
+  end
+  get "/user/:display_name/follow" => "follows#index"

Why `index`? Can you have multiple follows for one `:display_name`?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5261#pullrequestreview-2435666925
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5261/review/2435666925 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20241114/6640f76c/attachment.htm>


More information about the rails-dev mailing list