[openstreetmap/openstreetmap-website] Use CSS filter instead of dimming tiles (PR #5325)

Tim Weber notifications at github.com
Fri Nov 15 18:33:47 UTC 2024


@scy commented on this pull request.



> @@ -504,7 +504,13 @@ body.small-nav {
 @include color-mode(dark) {
   .leaflet-tile-container,
   .mapkey-table-entry td:first-child > * {
-    filter: brightness(.8);
+    filter: invert(100%) hue-rotate(180deg) brightness(95%) contrast(90%);

This PR isn't about proper testing, it's about fixing what has been rolled out without any.

That said, I agree with you that performance needs to be considered. However, that's gonna require more solid numbers than "I tested it on my device and it was stuttering".

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5325#discussion_r1844302716
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5325/review/2439364081 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20241115/b786707c/attachment-0001.htm>


More information about the rails-dev mailing list