[openstreetmap/openstreetmap-website] Dark mode menu (PR #5336)

Tim Weber notifications at github.com
Sat Nov 16 02:13:59 UTC 2024


@scy commented on this pull request.



> +  const darkModeMenuItems = [
+    {
+      name: "brightness100",
+      filter: "none"
+    },
+    {
+      name: "brightness80",
+      filter: "brightness(.8)"
+    },
+    {
+      name: "brightness60",
+      filter: "brightness(.6)"
+    },
+    {
+      name: "invert",
+      filter: "invert(.8) hue-rotate(180deg)"

I think .8 has pretty weak contrast and would suggest .95 instead. Or provide several options, like .8, .9, .95 and 1.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5336#pullrequestreview-2440193174
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5336/review/2440193174 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20241115/5d0e4663/attachment.htm>


More information about the rails-dev mailing list