[openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)
Marwin Hochfelsner
notifications at github.com
Sat Nov 16 14:52:55 UTC 2024
> For example, we got here believers in inverse+rotate. Why do they think that it's the best option? Probably because it generally works for the standard layer.
I'm generally in team invert, but here for the default of no filter. And I don't think layer-wise filters add more than they take away in removing a two-click global map appearance change. Wherever that control will go, it should be adjacent to the dark mode preference toggle. If all that can fit in the context menu like proposed in #5336 (think of how layer and detail flyouts on mobile) needs to be tested.
> We can put the options in the layer selector like #5324 (comment), but that's more custom javascript than we'd have otherwise.
With just three radio button "presets" (the user should be able to adapt them to their needs) and the CSS :has() it could work without additional JS entirely, further customization and compatibility already requires more js.
> just add a dark style in addition to the others
Dark or light mode exclusive layers don't seem right to me if they're not complementary, but the complementary dark variants of the currently featured layers both have flaws that I already pointed out in https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2479659101
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2480603330
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/issues/5328/2480603330 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20241116/cb31c368/attachment.htm>
More information about the rails-dev
mailing list