[openstreetmap/openstreetmap-website] Use CSS filter instead of dimming tiles (PR #5325)

Mateusz Konieczny notifications at github.com
Sat Nov 16 19:36:47 UTC 2024


> The only way people could continue using the OSM.org map was either by disabling dark mode for their whole browser (because that's a global setting both in Firefox and Chrome), or use a different browser just for looking at OSM

AFAIK map was still shown? At most it was really ugly/poorly readable. I would reserve claims "The only way people could continue" for actually fully broken site

> I don't see how the dimmed tiles would've been approved by anyone who cares about accessibility, or uses dark mode

people have different preferences, I for example avoid dark mode whenever possible but I am not going to write how anyone adding dark mode hates users and accessibility 

> It's been less than 22 hours since you opened it. I haven't reviewed this PR specifically, but you can see from the discussion in https://github.com/openstreetmap/openstreetmap-website/issues/5328 that there's lots to consider about the invert+rotate approach. It's not a PR which is a straightforward merge, and even if it was, 22 hours is asking a lot in terms of turnaround from a handful of volunteers.

+1

it is not really reasonable to expect PR review within 24 hours

for open source maintained by volunteers I would not expect it even for critical issues breaking critical systems (if that happens it is fault of anyone supposed to provide funding for these systems, and it was not actually making site unusable even if it was widely hated)

You have right to expect PR review within 24 hours if you have people paid specifically to do so.

I would advise to not rage-quit over this, openstreetmap-website would likely benefit from more developers (though there is also bottleneck at PR reviewing)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5325#issuecomment-2480752990
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5325/c2480752990 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20241116/092fee50/attachment.htm>


More information about the rails-dev mailing list