[openstreetmap/openstreetmap-website] Provide a truncated view of recent diaries (PR #5121)
David Tsiklauri
notifications at github.com
Mon Nov 18 10:16:10 UTC 2024
@nertc commented on this pull request.
> + def truncate_html(html, max_length, empty_tag_length = 500)
+ doc = Nokogiri::HTML::DocumentFragment.parse(html)
+ accumulated_length = 0
+ truncated_node = nil
+
+ doc.traverse do |node|
+ if accumulated_length >= max_length
+ node.remove unless truncated_node.ancestors.include?(node)
+ next
+ end
+
+ next unless node.children.empty?
+
+ content_length = node.text? ? node.text.length : empty_tag_length
+ if accumulated_length + content_length >= max_length
+ node.content = node.text.truncate(max_length - accumulated_length) if node.text?
What do you think is a good number for the limit?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5121#discussion_r1846278714
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5121/review/2442143841 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20241118/8e48da5a/attachment-0001.htm>
More information about the rails-dev
mailing list