[openstreetmap/openstreetmap-website] Note subscriptions API (PR #5314)
Andy Allan
notifications at github.com
Wed Nov 20 15:15:34 UTC 2024
Looks good to me. Only two small things:
* PR contains a fixup commit (i.e. a commit that changes code that itself is added by this PR)
* I'm not sure if the error messages should come from the translation system. Other usage of `report_error` is inconsistent whether error strings are translated or not.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5314#issuecomment-2488850936
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5314/c2488850936 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20241120/1f934dbd/attachment.htm>
More information about the rails-dev
mailing list