[openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

Anton Khorev notifications at github.com
Mon Nov 25 15:58:46 UTC 2024


> > This one: enable my rotation filter ignoring problems with hillshading?
> 
> @AntonKhorev You were the first person to point out that this a problem. So it took years to get any feedback.

I wasn't. Hillshading specifically was first mentioned by @gravitystorm here. There also was a predecessor issue #4769, not as specific as this one. You can see how much feedback it got (3 comments).

I knew that there are likely issues with inverse+rotate, that's why I didn't enable it in #4712, but I didn't investigate what these issues are. You can see that I'm linking to "OpenStreetMap Dark Theme" style. That style defaults to inverse+rotate which works fine for the standard layer. But in case it doesn't work, there's also a brightness selector:

![image](https://github.com/user-attachments/assets/88fb48f5-dbc5-43eb-b865-a334f249904d)

In https://github.com/openstreetmap/openstreetmap-website/pull/4712 I had to decide which filter to enable before we had any selector. After that I was going to add a selector but that didn't happen for other reasons.

> Now we have @hlfan's filters that we can use for the layers that have hillshading.

Did anyone try them with these layers?


-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2498412022
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/issues/5328/2498412022 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20241125/9b6fbd7f/attachment-0001.htm>


More information about the rails-dev mailing list