[openstreetmap/openstreetmap-website] Use system font on error pages (PR #5277)
Anton Khorev
notifications at github.com
Mon Oct 21 16:37:22 UTC 2024
I opened #5131 and put a number of changes to error pages to see which of them are acceptable. The discussion there however has been about making more changes. I guess that means nobody objects to the ones I made and we can have them merged.
This PR changes the font of error pages to a default system ui font. Bootstrap does the same thing except also adds fallback fonts for older browsers that don't understand `font-family: system-ui`. We don't need a serif font for a text this short because we don't use serif fonts even for longer texts on the website.
Addresses this from #3532:
> It also looks incredibly ugly, with loads of whitespace and the default browser font.

You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5277
-- Commit Summary --
* Use system font on error pages
-- File Changes --
M app/assets/stylesheets/errors.scss (4)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/5277.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5277.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5277
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5277 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20241021/6ec83c8b/attachment.htm>
More information about the rails-dev
mailing list