[openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)

David Tsiklauri notifications at github.com
Tue Oct 22 07:14:52 UTC 2024


@nertc commented on this pull request.



> @@ -280,8 +280,8 @@
   resource :profile, :only => [:edit, :update]
 
   # friendships
-  match "/user/:display_name/make_friend" => "friendships#make_friend", :via => [:get, :post], :as => "make_friend"
-  match "/user/:display_name/remove_friend" => "friendships#remove_friend", :via => [:get, :post], :as => "remove_friend"
+  match "/user/:display_name/follow_user" => "friendships#follow_user", :via => [:get, :post], :as => "follow_user"
+  match "/user/:display_name/unfollow_user" => "friendships#unfollow_user", :via => [:get, :post], :as => "unfollow_user"

When I started implementing same architecture as `user_mutes`, it caused to change some more files and add some complexities. This PR is already `+104 -104` line change. I think, it will be better to create a separate PR about changing routing architecture of the `follow` functionality after this PR will be merged to avoid making it even bigger and more complex.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5261#discussion_r1810085018
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5261/review/2384138497 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20241022/0a2f5a91/attachment.htm>


More information about the rails-dev mailing list