[openstreetmap/openstreetmap-website] Add social sharing functionality (PR #4985)

Anton Khorev notifications at github.com
Tue Oct 22 11:47:36 UTC 2024


@AntonKhorev commented on this pull request.



> @@ -0,0 +1,27 @@
+// Opening pop-ups with share URL
+function openShareUrl(url, initialWidth = 640, initialHeight = 480) {
+  if (typeof url !== "string" || !url.startsWith("http")) {
+    console.error("Invalid URL"); // Consider removing this line if console warnings should be avoided.
+    return;
+  }
+
+  const width = Math.max(100, Math.min(screen.width, initialWidth));
+  const height = Math.max(100, Math.min(screen.height, initialHeight));
+
+  const left = (screen.width / 2) - (width / 2);
+  const top = (screen.height * 0.3) - (height / 2);
+  const opts = `width=${width},height=${height},left=${left},top=${top},menubar=no,status=no,location=no`;
+
+  window.open(url, "popup", opts);

What happens if you replace your document ready listener with this?
```js
$(document).ready(function () {
  $(".ssb-icon").on("click", function (e) {
    const shareUrl = $(this).attr("href");
    if (!shareUrl.startsWith("mailto:")) {
      e.preventDefault();
      openShareUrl(shareUrl);
    }
  });
});
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4985#discussion_r1810571206
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4985/review/2384948500 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20241022/e51bf758/attachment.htm>


More information about the rails-dev mailing list