[openstreetmap/openstreetmap-website] Remove callback from initialize() in note js controller (PR #5289)

Anton Khorev notifications at github.com
Fri Oct 25 15:54:16 UTC 2024


https://github.com/openstreetmap/openstreetmap-website/commit/a796c41881c26e6da8828a71dbfb533613e5a83f added a callback to `function initialize()` in `note.js`. It's called at the very end of the function. Not scheduled in some event, not skipped by early termination, nothing runs after it. Passing a callback to `initialize()` is the same as running `initialize(); callback();`
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5289

-- Commit Summary --

  * Remove callback from initialize() in note js controller

-- File Changes --

    M app/assets/javascripts/index/note.js (22)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5289.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5289.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5289
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5289 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20241025/35a1cfb3/attachment.htm>


More information about the rails-dev mailing list