[openstreetmap/openstreetmap-website] Show "reporting user" on "issues" screen (PR #4990)

David Tsiklauri notifications at github.com
Thu Sep 5 06:34:13 UTC 2024


As https://github.com/openstreetmap/openstreetmap-website/pull/5057 is merged, this PR was updated to match pagination changes of the issues page.

In terms of performance, on the local machine I have 1000 users and 1000 issues, and pagination time was increased only by 150-200ms (it should be similar increase in the real environment, as before for the https://github.com/openstreetmap/openstreetmap-website/pull/5057 I tried to match up timing of the local and real environments).

All the Ruby variable initializations and calculations (from the previous solution) were moved from `issues/index.html.erb` file to `issues_controller.rb` to make html files less filled with calculation code.

Also, as we are using Bootstrap Tooltips in other places, `turbo_tooltip.js` file was created. [Bootstrap Tooltips Documentation](https://getbootstrap.com/docs/5.0/components/tooltips/) mentions:

> ... you must initialize them yourself

> Tooltips must be hidden before their corresponding elements have been removed from the DOM.

Because of these limitations, it has some bugs when working with Turbo (tooltips are not closing, tooltips got frozen on the top-left side of the screen ...). `turbo_tooltip.js` initializes Bootstrap Tooltips, solves the problem that caused tooltips bugs and also is reusable to be used in the future everywhere, where Turbo will be used and tooltips will be needed (Diary Entries page, Diary Entry Comments, User Blocks page ...).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4990#issuecomment-2330711700
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4990/c2330711700 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240904/3bce961c/attachment.htm>


More information about the rails-dev mailing list