[openstreetmap/openstreetmap-website] Switch from ubuntu to debian and refactor Dockerfile (PR #5157)
mmd
notifications at github.com
Thu Sep 5 19:22:49 UTC 2024
@mmd-osm commented on this pull request.
> - && echo "Package: *\nPin: release o=LP-PPA-mozillateam\nPin-Priority: 1001" > /etc/apt/preferences.d/mozilla-firefox \
- && apt-get install --no-install-recommends -y \
- firefox-geckodriver \
- && apt-get clean \
- && rm -rf /var/lib/apt/lists/*
-
-# Install compatible Osmosis to help users import sample data in a new instance
-RUN curl -OL https://github.com/openstreetmap/osmosis/releases/download/0.47.2/osmosis-0.47.2.tgz \
- && tar -C /usr/local -xzf osmosis-0.47.2.tgz
+RUN npm install --global yarn
+
+# Install geckodriver and firefox
+RUN apt-get update \
+ && apt-get install -y --no-install-recommends \
+ ca-certificates curl firefox-esr \
+ && curl -L https://github.com/mozilla/geckodriver/releases/download/v0.35.0/geckodriver-v0.35.0-linux64.tar.gz | tar xz -C /usr/local/bin
Tests are passing without downloading "curl -L https://github.com/mozilla/geckodriver/releases/..." first. So yes, installing geckodriver could be dropped as well.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5157#discussion_r1746054636
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5157/review/2283909239 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240905/229bc787/attachment.htm>
More information about the rails-dev
mailing list