[openstreetmap/openstreetmap-website] Add social sharing functionality (PR #4985)

[Anton Khorev]

@AntonKhorev commented on this pull request.



> +$(document).ready(function () {
+  $(".ssb-icon").on("click", function (e) {

This is not going to work with Turbo paging because `$(document).ready` won't happen when you click *Newer/Older Entries*. This can be fixed by delegating the event to something that stays on the page or the entire document, but the other question is: Should there be share buttons on multiple entry pages at all? We're also trying to truncate the entries on such pages, with #5121 or something like. You made your own version in #5125 and I don't see share buttons in it. Maybe the buttons should only be present on single entry pages?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4985#pullrequestreview-2284586894
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4985/review/2284586894 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240905/4dd28e33/attachment-0001.htm>