[openstreetmap/openstreetmap-website] Simplify routing endpoint interface, always do reverse geocoding (PR #5064)

Anton Khorev notifications at github.com
Sun Sep 8 08:02:06 UTC 2024


@AntonKhorev commented on this pull request.



>        input.val(json[0].display_name);
 
       changeCallback();
     });
   }
 
+  function getReverseGeocode() {
+    var latlng = endpoint.latlng.clone();
+    var reverseGeocodeUrl = OSM.NOMINATIM_URL + "reverse?lat=" + latlng.lat + "&lon=" + latlng.lng + "&format=json";

The location wouldn't snap in the same way is does on the currently deployed version. The pointer is not going to move, just the address would be too imprecise.

Ultimately we should control the precision but I didn't want to do it in this pull request, see https://github.com/openstreetmap/openstreetmap-website/pull/4904#discussion_r1723165682

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5064#discussion_r1749127492
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5064/review/2288474109 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240908/ac1bc72a/attachment.htm>


More information about the rails-dev mailing list