[openstreetmap/openstreetmap-website] Add social sharing functionality (PR #4985)
Emin Kocan
notifications at github.com
Tue Sep 10 07:16:27 UTC 2024
@kcne commented on this pull request.
> +$(document).ready(function () {
+ $(".ssb-icon").on("click", function (e) {
I agree on this one. While working on this, there was not too much information indicating someone is going to do such thing. If we are going to truncate the text, then this definitely should only be displayed on single entry pages. Although I'm not sure should I do it right away or wait for #5121 to be merged. Thank you.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4985#discussion_r1751393138
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/4985/review/2291564770 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240910/3ffdec77/attachment-0001.htm>
More information about the rails-dev
mailing list